[lkml]   [2009]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/2] rt2x00: Implement support for rt2800pci

    [ I somehow missed this one by not being on cc: ]

    On Thursday 15 October 2009 22:04:14 Ivo van Doorn wrote:
    > Add support for the rt2860/rt3090 chipsets from Ralink.
    > Includes various patches from a lot of people who helped
    > getting this driver into the current shape.
    > Signed-off-by: Alban Browaeys <>
    > Signed-off-by: Benoit PAPILLAULT <>
    > Signed-off-by: Felix Fietkau <>
    > Signed-off-by: Luis Correia <>
    > Signed-off-by: Mattias Nissler <>
    > Signed-off-by: Mark Asselstine <>
    > Signed-off-by: Xose Vazquez Perez <>
    > Signed-off-by: Ivo van Doorn <>
    > ---

    First let me say that I'm very happy to see this patch finally being
    submitted and I appreciate the effort..

    (I'll give it a spin on Eee 901 w/ 2.6.32-rc5 sometime later..)

    Now to the less happy part..

    I also used the opportunity to take a closer look at this driver and
    it seems that it needlessly adds around 2 KLOC to kernel by duplicating
    the common content of rt2800usb.h to rt2800pci.h instead of moving it
    to the shared header (like it is done in the staging crap drivers):

    $ wc -l drivers/net/wireless/rt2x00/rt2800usb.h drivers/net/wireless/rt2x00/rt2800pci.h
    1951 drivers/net/wireless/rt2x00/rt2800usb.h
    1960 drivers/net/wireless/rt2x00/rt2800pci.h
    3911 total

    $ diff -u drivers/net/wireless/rt2x00/rt2800usb.h drivers/net/wireless/rt2x00/rt2800pci.h|diffstat
    rt2800pci.h | 213 +++++++++++++++++++++++++++++++-----------------------------
    1 file changed, 111 insertions(+), 102 deletions(-)

    Similarly it looks like most of the code between rt2800usb.c and rt2800pci.c
    could also be shared (up to another 2 KLOC saved) by adding abstraction layer
    for accessing chipset registers over different buses (again like it is done
    in staging crap drivers):

    $ wc -l drivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800pci.c
    3077 drivers/net/wireless/rt2x00/rt2800usb.c
    3323 drivers/net/wireless/rt2x00/rt2800pci.c
    6400 total

    $ diff -u drivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800pci.c|diffstat
    rt2800pci.c | 2190 +++++++++++++++++++++++++++++++++---------------------------
    1 file changed, 1218 insertions(+), 972 deletions(-)

    [ for better visualization of issues raised diffs themselves are available at: ]

    All in all, the total amount of the kernel code needed for implementing
    rt2800pci functionality should 1-2 KLOC instead of the current 5 KLOC.

     \ /
      Last update: 2009-10-17 16:57    [W:0.022 / U:34.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site