lkml.org 
[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: powerpc: introduce asm/swab.h
On Tue, Jan 06, 2009 at 09:11:42PM -0800, Linus Torvalds wrote:
>
>
> On Wed, 7 Jan 2009, Benjamin Herrenschmidt wrote:
> >
> > Even if fixing that to use __swab32() instead, then it fails because
> > this is defined after it's used. I worked around it using fswab in
> > there instead.
>
> That's the same patch I just sent out (but you changed comments too), so I
> obviously agree.
>
> x86 didn't see this (even in 32-bit mode) because it doesn't use that odd
> __SWAB_64_THRU_32__ case, but does the 64-bit swab with native code.
>
> Can you also verify that it works for you (not just compiles), just so
> that I can commit it?

I'm the one that originally told Ben about this breaking the PPC32 build.
His patch compiles on my PPC32 box. I just rebooted with the new kernel
and it boots.

Tested-by: Steven Rostedt <srostedt@redhat.com>

-- Steve



\
 
 \ /
  Last update: 2009-01-07 06:41    [W:0.069 / U:3.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site