Messages in this thread | | | Date | Wed, 07 Jan 2009 00:19:07 -0500 (EST) | From | Nicolas Pitre <> | Subject | Re: powerpc: introduce asm/swab.h |
| |
On Tue, 6 Jan 2009, Linus Torvalds wrote:
> > > On Wed, 7 Jan 2009, Benjamin Herrenschmidt wrote: > > > > Even if fixing that to use __swab32() instead, then it fails because > > this is defined after it's used. I worked around it using fswab in > > there instead. > > That's the same patch I just sent out (but you changed comments too), so I > obviously agree. > > x86 didn't see this (even in 32-bit mode) because it doesn't use that odd > __SWAB_64_THRU_32__ case, but does the 64-bit swab with native code. > > Can you also verify that it works for you (not just compiles), just so > that I can commit it?
Tested OK on ARM (using LE mode with networking, etc.)
Nicolas
| |