Messages in this thread Patch in this message | | | Date | Sat, 31 Jan 2009 13:42:36 +0100 | From | Roel Kluin <> | Subject | [PATCH] sungem: limit reaches -1, but 0 tested |
| |
With a postfix decrement these reach -1 rather than 0, but after the loop it is tested to have become 0.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c index 61843fd..78f8cee 100644 --- a/drivers/net/sungem_phy.c +++ b/drivers/net/sungem_phy.c @@ -79,7 +79,7 @@ static int reset_one_mii_phy(struct mii_phy* phy, int phy_id) udelay(100); - while (limit--) { + while (--limit) { val = __phy_read(phy, phy_id, MII_BMCR); if ((val & BMCR_RESET) == 0) break;
| |