lkml.org 
[lkml]   [2009]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found
    On Fri, 30 Jan 2009 10:26:54 +0100 Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:

    > [CCs added]
    >
    > Hans-Christian Egtvedt wrote:
    > > This patch replaces the dev_dbg(...) with a pr_err since the ssc pointer
    > > is not valid when the id is not found in the list.
    > >
    > > Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
    >
    > Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
    >
    > ...or should I just apply it to the avr32 tree?
    >

    Is OK, I tossed into onto my 2.6.29 pile.

    Should it be backported to 2.6.28.x or earlier?

    >
    > > ---
    > > drivers/misc/atmel-ssc.c | 2 +-
    > > 1 files changed, 1 insertions(+), 1 deletions(-)
    > >
    > > diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
    > > index 6b35874..6cff1bb 100644
    > > --- a/drivers/misc/atmel-ssc.c
    > > +++ b/drivers/misc/atmel-ssc.c
    > > @@ -35,7 +35,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num)
    > >
    > > if (!ssc_valid) {
    > > spin_unlock(&user_lock);
    > > - dev_dbg(&ssc->pdev->dev, "could not find requested device\n");
    > > + pr_err("ssc: ssc%d platform device is missing\n", ssc_num);
    > > return ERR_PTR(-ENODEV);
    > > }
    > >


    \
     
     \ /
      Last update: 2009-01-30 10:39    [W:0.037 / U:5.212 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site