Messages in this thread | | | Date | Thu, 29 Jan 2009 15:50:42 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found |
| |
On Thu, 29 Jan 2009 17:46:55 +0100 Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> wrote:
> On Mon, 19 Jan 2009 13:57:56 +0100 > Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> wrote: > > This patch replaces the dev_dbg(...) with a pr_err since the ssc > > pointer is not valid when the id is not found in the list. > > > > Signed-off-by: Hans-Christian Egtvedt > > <hans-christian.egtvedt@atmel.com> --- > > drivers/misc/atmel-ssc.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c > > index 6b35874..6cff1bb 100644 > > --- a/drivers/misc/atmel-ssc.c > > +++ b/drivers/misc/atmel-ssc.c > > @@ -35,7 +35,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num) > > > > if (!ssc_valid) { > > spin_unlock(&user_lock); > > - dev_dbg(&ssc->pdev->dev, "could not find requested device\n"); > > + pr_err("ssc: ssc%d platform device is missing\n", ssc_num); > > return ERR_PTR(-ENODEV); > > } > > > > Bump, or did I miss the merge window? >
(Top-posting repaired. Please don't do that! It makes it horrid to reply to you)
(Suitable cc's added - this was why your patch got lost)
The patch seems reasonable but the changelog seems to be quite misleading. I did this:
The ssc pointer is not valid when the id is not found in the list. Convert the message from a debug one into an error message and avoid dereferencing the bad pointer.
OK?
| |