lkml.org 
[lkml]   [2009]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] x86, um: fix GETREG/PUTREG macros
When these macros aren't called with regs, e.g. with foo
this will incorectly expand to foo->foo.gp[*]

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
My other patch should probably as well have been sent to this list:
http://lkml.org/lkml/2009/1/21/203

diff --git a/arch/um/sys-x86_64/signal.c b/arch/um/sys-x86_64/signal.c
index 1a899a7..31d0e9c 100644
--- a/arch/um/sys-x86_64/signal.c
+++ b/arch/um/sys-x86_64/signal.c
@@ -49,8 +49,8 @@ static int copy_sc_from_user(struct pt_regs *regs,
struct user_i387_struct fp;
int err = 0;

-#define GETREG(regs, regno, sc, regname) \
- __get_user((regs)->regs.gp[(regno) / sizeof(unsigned long)], \
+#define GETREG(_regs, regno, sc, regname) \
+ __get_user((_regs)->regs.gp[(regno) / sizeof(unsigned long)], \
&(sc)->regname)

err |= GETREG(regs, R8, from, r8);
@@ -104,8 +104,8 @@ static int copy_sc_to_user(struct sigcontext __user *to,
err |= __put_user(0, &to->gs);
err |= __put_user(0, &to->fs);

-#define PUTREG(regs, regno, sc, regname) \
- __put_user((regs)->regs.gp[(regno) / sizeof(unsigned long)], \
+#define PUTREG(_regs, regno, sc, regname) \
+ __put_user((_regs)->regs.gp[(regno) / sizeof(unsigned long)], \
&(sc)->regname)

err |= PUTREG(regs, RDI, to, di);


\
 
 \ /
  Last update: 2009-01-21 16:19    [W:1.731 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site