Messages in this thread | | | From | Janne Grunau <> | Subject | Re: [PATCH 01/18] lirc core device driver infrastructure | Date | Tue, 9 Sep 2008 15:10:26 +0200 |
| |
On Tuesday 09 September 2008 14:33:35 Sebastian Siewior wrote: > * Janne Grunau | 2008-09-09 11:53:48 [+0200]: > >> >+ > >> >+ bytes_in_key = p->code_length/8 + (p->code_length%8 ? 1 : 0); > >> > >> did you actually pass checkpatch.pl ? > > > >yes, and while this is ugly I see no obvious CodingStyle violation. > > > >is following better? > > > >bytes_in_key = p->code_length/8; > >if (p->code_length%8) > > bytes_in_key++; > > bytes_in_key = p->code_length / 8; > if (p->code_length % 8) > bytes_in_key++; > > I meant the missing spaces around / and %. Looking now at it, it > seems that it behaves like DIV_ROUND_UP(). The magic of spaces :)
There is also BITS_TO_LONGS(x) which does the intended. I found it only since it uses DIV_ROUND_UP. Will use that. Thanks.
Janne
| |