lkml.org 
[lkml]   [2008]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 5/6] Added flush_disk to factor out common buffer cache flushing code.
Date
Andrew Patterson <andrew.patterson@hp.com> writes:

> Added flush_disk to factor out common buffer cache flushing code.
>
> We need to be able to flush the buffer cache for for more than
> just when a disk is changed, so we factor out common cache flush code
> in check_disk_change() to an internal flush_disk() routine. This
> routine will then be used for both disk changes and disk resizes (in a
> later patch).
>
> Include the disk name in the text indicating that there are busy
> inodes on the device and increase the KERN severity of the message.
>
> Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

> +static void flush_disk(struct block_device *bdev)
> +{
> + if (__invalidate_device(bdev)) {
> + char name[BDEVNAME_SIZE] = "";
> +
> + if (bdev->bd_disk)
> + disk_name(bdev->bd_disk, 0, name);
> + printk(KERN_WARNING "VFS: busy inodes on changed media %s\n",
> + name);
> + }

This message will scare folks growing their devices online. Can you
think of some better verbiage for this?


\
 
 \ /
  Last update: 2008-09-03 20:45    [W:0.169 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site