lkml.org 
[lkml]   [2008]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/6] Added flush_disk to factor out common buffer cache flushing code.
    Date
    Added flush_disk to factor out common buffer cache flushing code.

    We need to be able to flush the buffer cache for for more than
    just when a disk is changed, so we factor out common cache flush code
    in check_disk_change() to an internal flush_disk() routine. This
    routine will then be used for both disk changes and disk resizes (in a
    later patch).

    Include the disk name in the text indicating that there are busy
    inodes on the device and increase the KERN severity of the message.

    Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
    ---

    fs/block_dev.c | 33 ++++++++++++++++++++++++++++-----
    1 files changed, 28 insertions(+), 5 deletions(-)


    diff --git a/fs/block_dev.c b/fs/block_dev.c
    index f8df73a..5ce28b1 100644
    --- a/fs/block_dev.c
    +++ b/fs/block_dev.c
    @@ -868,6 +868,33 @@ struct block_device *open_by_devnum(dev_t dev, unsigned mode)

    EXPORT_SYMBOL(open_by_devnum);

    +
    +/**
    + * flush_disk - invalidates all buffer-cache entries on a disk
    + *
    + * @bdev: struct block device to be flushed
    + *
    + * Invalidates all buffer-cache entries on a disk. It should be called
    + * when a disk has been changed -- either by a media change or online
    + * resize.
    + */
    +static void flush_disk(struct block_device *bdev)
    +{
    + if (__invalidate_device(bdev)) {
    + char name[BDEVNAME_SIZE] = "";
    +
    + if (bdev->bd_disk)
    + disk_name(bdev->bd_disk, 0, name);
    + printk(KERN_WARNING "VFS: busy inodes on changed media %s\n",
    + name);
    + }
    +
    + if (!bdev->bd_disk)
    + return;
    + if (bdev->bd_disk->minors > 1)
    + bdev->bd_invalidated = 1;
    +}
    +
    /**
    * check_disk_size_change - checks for disk size change and adjusts
    * bdev size.
    @@ -945,13 +972,9 @@ int check_disk_change(struct block_device *bdev)
    if (!bdops->media_changed(bdev->bd_disk))
    return 0;

    - if (__invalidate_device(bdev))
    - printk("VFS: busy inodes on changed media.\n");
    -
    + flush_disk(bdev);
    if (bdops->revalidate_disk)
    bdops->revalidate_disk(bdev->bd_disk);
    - if (bdev->bd_disk->minors > 1)
    - bdev->bd_invalidated = 1;
    return 1;
    }



    \
     
     \ /
      Last update: 2008-08-30 01:19    [W:0.023 / U:30.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site