Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function | Date | Mon, 29 Sep 2008 11:26:41 -0700 |
| |
On Monday, September 29, 2008 11:15 am Arjan van de Ven wrote: > On Mon, 29 Sep 2008 18:45:19 +0100 > > Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > > > This is the same like pci_iomap(pdev, number, 0), no? > > > > > > Yeah... Looks like that function isn't that widely used though. Is > > > the maxlen param really needed? Looks like the drivers that use it > > > often pass 0 or the > > > > In some cases yes you do need the length. > > so we should have a 2nd api for those "some cases", that's ok.
Right, I'm definitely not suggesting that we don't provide a way to provide length, but if 90+% of callers don't need it, we should probably have a simpler API that does the bare minimum.
Jesse
| |