lkml.org 
[lkml]   [2008]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function
On Mon, 29 Sep 2008 18:45:19 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> > > This is the same like pci_iomap(pdev, number, 0), no?
> >
> > Yeah... Looks like that function isn't that widely used though. Is
> > the maxlen param really needed? Looks like the drivers that use it
> > often pass 0 or the
>
> In some cases yes you do need the length.

so we should have a 2nd api for those "some cases", that's ok.

>
> > BAR length anyway, and Arjan converted existing drivers too, which
> > is where the real work is.
>
> He could have converted them to the existing perfectly good API not
> invented another one. He still can - I'm sure its a perl one liner to
> redo them in terms of pci_iomap()

pci_iomap() assumes you're using the rest of the iomap API as well!

most drivers do not do that.




--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org


\
 
 \ /
  Last update: 2008-09-29 20:19    [W:0.121 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site