Messages in this thread | | | Date | Mon, 29 Sep 2008 11:15:58 -0700 | From | Arjan van de Ven <> | Subject | Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function |
| |
On Mon, 29 Sep 2008 18:45:19 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > > This is the same like pci_iomap(pdev, number, 0), no? > > > > Yeah... Looks like that function isn't that widely used though. Is > > the maxlen param really needed? Looks like the drivers that use it > > often pass 0 or the > > In some cases yes you do need the length.
so we should have a 2nd api for those "some cases", that's ok.
> > > BAR length anyway, and Arjan converted existing drivers too, which > > is where the real work is. > > He could have converted them to the existing perfectly good API not > invented another one. He still can - I'm sure its a perl one liner to > redo them in terms of pci_iomap()
pci_iomap() assumes you're using the rest of the iomap API as well!
most drivers do not do that.
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |