Messages in this thread | | | Date | Fri, 19 Sep 2008 16:01:40 +0000 (GMT) | From | Michael Trimarchi <> | Subject | Re: [PATCH] atmel_serial: update the powersave handler to match serial core |
| |
Hi,
(I'll change my mailer soon ...), sorry if I break the thread.
----- Messaggio originale ----- > Da: Haavard Skinnemoen <haavard.skinnemoen@atmel.com> > A: Michael Trimarchi <trimarchimichael@yahoo.it> > Cc: linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Victor <linux@maxim.org.za>; Anti Sullin <anti.sullin@artecdesign.ee> > Inviato: Venerdì 19 settembre 2008, 17:46:15 > Oggetto: Re: [PATCH] atmel_serial: update the powersave handler to match serial core > > Michael Trimarchi wrote: > > > + /* we can not wake up if we're running on slow clock */ > > > + atmel_port->may_wakeup = device_may_wakeup(&pdev->dev); > > > + if (atmel_serial_clk_will_stop()) > > > + device_set_wakeup_enable(&pdev->dev, 0); > > > + > > This is not true, the wakeup in the slow clock is possible, configure the > > input pin of the serial device as a gpio, and wake up on gpio. Then you > > must reconfigure as a serial pin, and you can wake up on slow clock. > > Yes, but the current driver doesn't actually support that, does it? >
Yes I know, but we can think about it and support when is possible to wake-up the serial device. Each serial device can change the status of the gpio-pin before suspendig and register and handler on it (I think one interrupt handler for all the serial that can do that), then reset it after resume. I think not all the serial device can do that in the atmel architectures but I suppose that can be very usefull for example in gprs application.
> This patch doesn't really change that assumption anyway -- it just > implements it in a way more consistent with the current serial core. >
> Haavard
Regards Michael
__________________________________________________ Do You Yahoo!? Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi http://mail.yahoo.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |