Messages in this thread | | | Date | Wed, 17 Sep 2008 15:43:06 -0600 | From | Alex Chiang <> | Subject | Re: [PATCH 3/5] pci: using pci_printk |
| |
* Alexey Dobriyan <adobriyan@gmail.com>: > On Tue, Sep 16, 2008 at 01:52:52AM -0700, Yinghai Lu wrote: > > --- linux-2.6.orig/drivers/pci/probe.c > > +++ linux-2.6/drivers/pci/probe.c > > @@ -304,7 +304,7 @@ static int __pci_read_base(struct pci_de > > > - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n", > > + pci_printk(KERN_LOG_DEBUG, KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n", > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > Brilliant, simply brilliant!
Yeah, that's ugly.
> Printk haters club is definitely creative, no questions.
Bjorn might have some useful advice here.
Also, didn't we recently get all the PCI printk output to resemble what lspci shows us?
/ac
| |