Messages in this thread | | | Date | Tue, 16 Sep 2008 19:18:14 +0200 | From | Robert Richter <> | Subject | Re: [PATCH 3/5] pci: using pci_printk |
| |
On 16.09.08 14:20:52, Alexey Dobriyan wrote: > On Tue, Sep 16, 2008 at 01:52:52AM -0700, Yinghai Lu wrote: > > --- linux-2.6.orig/drivers/pci/probe.c > > +++ linux-2.6/drivers/pci/probe.c > > @@ -304,7 +304,7 @@ static int __pci_read_base(struct pci_de > > > - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n", > > + pci_printk(KERN_LOG_DEBUG, KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n", > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Brilliant, simply brilliant!
Wouldn't it be much simpler to have an i/f as for dev_dbg() and also run the log level check only for debug messages? And, the dev_dbg() macro seems to have code that can be binary pached (?) to enable it if the compile option is not set.
-Robert
#define dev_dbg(dev, format, arg...) \ ({ if (0) dev_printk(KERN_DEBUG, dev, format, ##arg); 0; })
-- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com
| |