Messages in this thread | | | Date | Wed, 17 Sep 2008 23:46:53 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 1/3] [MTD] physmap.c: Check return of platform_device_register() |
| |
I just wrote:
>>> The PHYSMAP_COMPAT code had been ignoring the return value of >>> platform_device_register() in the physmap_init() function.
>>> Signed-off-by: Zev Weiss <zevweiss@gmail.com>
> [...]
>>> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c >>> index 42d844f..6fba0d4 100644 >>> --- a/drivers/mtd/maps/physmap.c >>> +++ b/drivers/mtd/maps/physmap.c >>> @@ -312,7 +312,7 @@ static int __init physmap_init(void) >>> err = platform_driver_register(&physmap_flash_driver); >>> #ifdef PHYSMAP_COMPAT >>> if (err == 0) >>> - platform_device_register(&physmap_flash); >>> + err = platform_device_register(&physmap_flash); >>> #endif >>> >>> return err;
[...]
>> Presumably we should run platform_driver_unregister() if the >> platform_device_register() failed.
> Why is that? There could be "normal" platform devices out there...
With that said, the patch is pointless (as already noted by Lennert).
WBR, Sergei
| |