Messages in this thread | | | Date | Wed, 17 Sep 2008 11:57:46 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/3] [MTD] physmap.c: Check return of platform_device_register() |
| |
On Fri, 12 Sep 2008 23:32:58 -0700 Zev Weiss <zevweiss@gmail.com> wrote:
> The PHYSMAP_COMPAT code had been ignoring the return value of > platform_device_register() in the physmap_init() function. > > Signed-off-by: Zev Weiss <zevweiss@gmail.com> > --- > drivers/mtd/maps/physmap.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c > index 42d844f..6fba0d4 100644 > --- a/drivers/mtd/maps/physmap.c > +++ b/drivers/mtd/maps/physmap.c > @@ -312,7 +312,7 @@ static int __init physmap_init(void) > err = platform_driver_register(&physmap_flash_driver); > #ifdef PHYSMAP_COMPAT > if (err == 0) > - platform_device_register(&physmap_flash); > + err = platform_device_register(&physmap_flash); > #endif > > return err;
Your email client is performing space-stuffing, thus making the patches unapplyable.
Presumably we should run platform_driver_unregister() if the platform_device_register() failed.
| |