lkml.org 
[lkml]   [2008]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp> wrote:

> Protecting file->f_pos with a lock adds some overhead but I think we should
> fix this.
> I used seqlock to serialize the access to file->f_pos. This approach is
> similar to inode->i_size synchronization.
>
> Comments?

> + if (offset != file_pos_read(file))
> + file_pos_write(file, offset);

Maybe file_pos_write should do this check?



\
 
 \ /
  Last update: 2008-09-16 17:25    [W:2.507 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site