Messages in this thread | | | Date | Wed, 10 Sep 2008 10:45:13 -0700 | From | Chris Leech <> | Subject | Re: [Open-FCoE] [PATCH 1/3] 24-bit types: typedef and macros for accessing 3-byte arrays as integers |
| |
Chris Leech wrote: > Dave Kleikamp wrote: >> @@ -62,7 +60,7 @@ struct timestruc_t { >> */ >> typedef struct { >> unsigned len:24; >> - unsigned off1:8; >> + u8 off1; >> u32 off2; >> } lxd_t; > > Shouldn't len here be changed to a __le24? I think this just changed > the size of lxd_t by a byte.
Never mind, I see that it's a host order field. And presently surprised to see that gcc combines the 24-bit bitfield with the following u8.
Chris
| |