lkml.org 
[lkml]   [2008]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Open-FCoE] [PATCH 1/3] 24-bit types: typedef and macros for accessing 3-byte arrays as integers
Chris Leech wrote:
> Dave Kleikamp wrote:
>> @@ -62,7 +60,7 @@ struct timestruc_t {
>> */
>> typedef struct {
>> unsigned len:24;
>> - unsigned off1:8;
>> + u8 off1;
>> u32 off2;
>> } lxd_t;
>
> Shouldn't len here be changed to a __le24? I think this just changed
> the size of lxd_t by a byte.

Never mind, I see that it's a host order field. And presently surprised
to see that gcc combines the 24-bit bitfield with the following u8.

Chris


\
 
 \ /
  Last update: 2008-09-10 19:47    [W:1.555 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site