lkml.org 
[lkml]   [2008]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] 24-bit types: typedef and macros for accessing 3-byte arrays as integers
Dave Kleikamp wrote:
> On Wed, 2008-09-10 at 10:07 -0400, Christoph Hellwig wrote:
>
>> JFS already defines an __le24, see fs/jfs/endian24.h. Please try to
>> cover it, too or at least make sure you don't break it.
>
> Chris,
> This patch takes care of jfs. Please add it to your patchset.
>
> Thanks,
> Shaggy

Thanks, I was just about to look into JFS.

> @@ -62,7 +60,7 @@ struct timestruc_t {
> */
> typedef struct {
> unsigned len:24;
> - unsigned off1:8;
> + u8 off1;
> u32 off2;
> } lxd_t;

Shouldn't len here be changed to a __le24? I think this just changed
the size of lxd_t by a byte.

- Chris


\
 
 \ /
  Last update: 2008-09-10 18:27    [from the cache]
©2003-2011 Jasper Spaans