lkml.org 
[lkml]   [2008]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Switching TestSetPageLocked to trylock_page
Date
On Thursday 31 July 2008 17:26, Nick Piggin wrote:
> Hi,
>
> I'm wondering if I could get a patch merged which changes all
> TestSetPageLocked and replaces them with trylock_page?

Yes? No?

The alternative is try to merge it via -mm or -next, but that just
wastes everybodies time with conflicts of having these differences
between -mm and mainline.


>
> It would be done so there are no functional changes.
>
> The reason I want to (aside from having a slightly more
> intuitive API), is to facilitate the implementation of lockdep
> on page lock, and also to use lock semantics bitops for the
> lock rather than the big-hammer barriers that come with
> test_and_set_bit.
>
> The lock bitops stuff is one of the parts of my patchset to speed
> up page lock functions (which results in nearly 50% faster
> pagecache throughput on my G5, and even slightly faster on x86)...
>
> Anyway, I remember you said these kinds of changes are appropriate
> for just after -rc1, and I agree it shouldn't cause much pain.
>
> Fixing up patch conflicts is literally a matter of
> s/!TestSetPageLocked/trylock_page
> s/TestSetPageLocked/!trylock_page
>
> Thoughts?


\
 
 \ /
  Last update: 2008-08-05 05:17    [W:0.109 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site