Messages in this thread | | | Date | Fri, 29 Aug 2008 15:31:55 -0700 | From | Aaron Straus <> | Subject | Re: drivers/char/random.c line 728 BUG |
| |
Hi,
On Aug 29 12:48 PM, Andrew Morton wrote: > yep, I would agree with all that.
Thanks for responding.
> How's this look?
Quick question off list... below
> - if (r == &input_pool && > - r->entropy_count >= random_read_wakeup_thresh) { > + if (r == &input_pool && entropy_count >= random_read_wakeup_thresh) { > wake_up_interruptible(&random_read_wait); > kill_fasync(&fasync, SIGIO, POLL_IN); > } > - > + r->entropy_count = entropy_count;
Here you set the entropy_count in the pool *after* waking up the reader. I was a little worried the reader would find the entropy_count unchanged and go back to sleep.
Regards, =a=
-- =================== Aaron Straus aaron@merfinllc.com
| |