lkml.org 
[lkml]   [2008]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: drivers/char/random.c line 728 BUG
Hi Matt,

On Sep 03 01:18 PM, Matt Mackall wrote:
> This fix is bogus - it assumes that r->entropy_count has atomic
> assignment which is not universally true (witness the existence of
> atomic_t). So we can still observe partial updates to entropy_count on
> some architectures. Now it's probably the case that we'll never see a
> partial update that actually triggers the BUG_ON, but it's still
> conceptually wrong to do things this way.

I think Andrew was just being safe by reverting to the old behavior.

Could we still apply his patch for the upcoming stable tree and fix it
the "right" way at some point in the future?

Thanks,
=a=

--
===================
Aaron Straus
aaron@merfinllc.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-09-03 20:31    [W:0.116 / U:15.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site