Messages in this thread | | | Subject | Re: [ipw3945-devel] [PATCH 1/1] iwlwifi: fix printk newlines | From | Marcel Holtmann <> | Date | Tue, 12 Aug 2008 05:59:25 +0200 |
| |
Hi Yi,
> > > s = iwl4965_get_sub_band(priv, channel); > > > if (s >= EEPROM_TX_POWER_BANDS) { > > > - IWL_ERROR("Tx Power can not find channel %d ", > > channel); > > > + IWL_ERROR("Tx Power can not find channel %d\n", > > channel); > > > return -1; > > > } > > > > can we not just fix IWL_ERROR to always append the newline? > > We should give the users more control to the style I think.
what kind of control do you expect? If you need two lines of debug or error output, call IWL_ERROR twice. This will also result in the KERN_ERR is set and not forgotten since that has to follow the newline.
Regards
Marcel
| |