Messages in this thread | | | Subject | Re: [ipw3945-devel] [PATCH 1/1] iwlwifi: fix printk newlines | From | Zhu Yi <> | Date | Tue, 12 Aug 2008 13:38:16 +0800 |
| |
On Tue, 2008-08-12 at 05:59 +0200, Marcel Holtmann wrote: > > We should give the users more control to the style I think. > > what kind of control do you expect? If you need two lines of debug or > error output, call IWL_ERROR twice. This will also result in the > KERN_ERR is set and not forgotten since that has to follow the > newline.
I thought sometimes we might not need a new line between two IWL_ERRORs. But your KERN_ERR garbaging the output in this case is correct. I think when we wrote the macro, we just follow the style of dev_info() ... dev_emerg() macros. Do you know why there is not a new line for them by default?
Thanks, -yi
| |