Messages in this thread | | | Subject | Re: [PATCH] mISDN cleanup user interface | From | Marcel Holtmann <> | Date | Tue, 29 Jul 2008 23:02:10 +0200 |
| |
Hi Karsten,
> > Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/kkeil/ISDN-2.6.git master > > > > The channelmap should have the same size on 32 and 64 bit > > systems. Thanks to David Woodhouse for spotting this. > > > > Signed-off-by: Karsten Keil <kkeil@suse.de> > > Er, isn't that still broken? Consider 32-bit userspace on 64-bit kernel, > big-endian.
I agree with David here. Please lets not do these horribly things again. Almost everybody has done their fair share of brokenness with the compat layers. Especially 32-bit userspace on 64-bit kernels. Using __u32 and alike is a way better choice and less headache.
Regards
Marcel
| |