Messages in this thread | | | Date | Wed, 30 Jul 2008 17:08:20 +0200 | From | Karsten Keil <> | Subject | Re: [PATCH] mISDN cleanup user interface |
| |
On Tue, Jul 29, 2008 at 09:22:26PM +0100, David Woodhouse wrote: > On Tue, 2008-07-29 at 21:56 +0200, Karsten Keil wrote: > > Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/kkeil/ISDN-2.6.git master > > > > The channelmap should have the same size on 32 and 64 bit > > systems. Thanks to David Woodhouse for spotting this. > > > > Signed-off-by: Karsten Keil <kkeil@suse.de> > > Er, isn't that still broken? Consider 32-bit userspace on 64-bit kernel, > big-endian. >
URGH, you are right, using the bit operations here is not a good idea at all and currently we also need not to be atomic for this map so we can use a bytearray and simple operation here.
-- Karsten Keil SuSE Labs ISDN and VOIP development SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
| |