lkml.org 
[lkml]   [2008]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Traffic control cgroups subsystem
Andrew Morton wrote:
> On Tue, 22 Jul 2008 10:44:18 -0700 (PDT)
> Ranjit Manomohan <ranjitm@google.com> wrote:
>
>> @@ -359,7 +370,12 @@ static int flow_classify(struct sk_buff *skb, struct tcf_proto *tp,
>> classid %= f->divisor;
>>
>> res->class = 0;
>> - res->classid = TC_H_MAKE(f->baseclass, f->baseclass + classid);
>> +
>> + if (key == FLOW_KEY_CGROUP_CLASSID)
>> + res->classid = TC_H_MAKE(f->baseclass, classid);
>> + else
>> + res->classid = TC_H_MAKE(f->baseclass,
>> + f->baseclass + classid);
>
> This causes a warning:
>
> net/sched/cls_flow.c: In function 'flow_classify':
> net/sched/cls_flow.c:344: warning: 'key' may be used uninitialized in this function
>
> that warning is a non-issue if we happen to know that f->nkeys can
> never be zero. I don't know if that is guaranteed at this code site?

It is by the flow_change() function, but special casing the
CGROUP_CLASSID is not acceptable anyway. There should be no
need for that, a simple linear mapping to classids is done
by default in mapping mode, the sk_cgroup_classid simply
shouldn't include qdisc IDs.


\
 
 \ /
  Last update: 2008-07-24 00:37    [W:0.101 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site