Messages in this thread | | | Date | Wed, 2 Jul 2008 14:54:00 +0200 | From | "Hans J. Koch" <> | Subject | Re: [PATCH] uio: User IRQ Mode |
| |
On Wed, Jul 02, 2008 at 07:59:51PM +0900, Magnus Damm wrote: > From: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com> > > This patch adds a "User IRQ Mode" to UIO. In this mode the user space driver > is responsible for acknowledging and re-enabling the interrupt.
This can easily be done without your patch.
> Shared interrupts are not supported by this mode. > > Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com> > Signed-off-by: Magnus Damm <damm@igel.co.jp> > --- > > Similar code has been posted some time ago as: > "[PATCH] uio_pdrv: Unique IRQ Mode" > "[PATCH 00/03][RFC] Reusable UIO Platform Driver".
Yes, and in that thread I gave detailed explanations why I won't accept that.
> > Changes since Uwe's last version: > - flags should be unsigned long > - simplify uio_userirq_handler()
That's nearly nothing. All you do is sending the same stuff three weeks later in the hope somebody will merge it this time. NAK.
Thanks, Hans
> > Needs "[PATCH 0/1] UIO: Add a write() function to enable/disable interrupts" > > include/linux/uio_driver.h | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > --- 0020/include/linux/uio_driver.h > +++ work/include/linux/uio_driver.h 2008-07-02 19:45:55.000000000 +0900 > @@ -17,6 +17,7 @@ > #include <linux/module.h> > #include <linux/fs.h> > #include <linux/interrupt.h> > +#include <linux/bitops.h> > > struct uio_map; > > @@ -63,6 +64,7 @@ struct uio_info { > long irq; > unsigned long irq_flags; > void *priv; > + unsigned long flags; > irqreturn_t (*handler)(int irq, struct uio_info *dev_info); > int (*mmap)(struct uio_info *info, struct vm_area_struct *vma); > int (*open)(struct uio_info *info, struct inode *inode); > @@ -92,4 +94,31 @@ extern void uio_event_notify(struct uio_ > #define UIO_MEM_LOGICAL 2 > #define UIO_MEM_VIRTUAL 3 > > +/* defines for uio_info->flags */ > +#define UIO_FLAGS_IRQDISABLED 0 > + > +static inline irqreturn_t uio_userirq_handler(int irq, > + struct uio_info *dev_info) > +{ > + int ret = -1; > + > + if (likely(dev_info->irqcontrol)) > + ret = dev_info->irqcontrol(dev_info, 0); > + > + return IRQ_RETVAL(ret == 0); > +} > + > +static inline int uio_userirq_irqcontrol(struct uio_info *info, s32 irq_on) > +{ > + if (irq_on) { > + if (test_and_clear_bit(UIO_FLAGS_IRQDISABLED, &info->flags)) > + enable_irq(info->irq); > + } else { > + if (!test_and_set_bit(UIO_FLAGS_IRQDISABLED, &info->flags)) > + disable_irq(info->irq); > + } > + > + return 0; > +} > + > #endif /* _LINUX_UIO_DRIVER_H_ */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |