[lkml]   [2008]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] uio: User IRQ Mode
On Thu, Jul 03, 2008 at 02:45:05PM +0200, Hans J. Koch wrote:
> On Thu, Jul 03, 2008 at 09:10:19AM +0200, Uwe Kleine-K??nig wrote:
> > Moreover this might prevent some bugs. (And obviously this
> > function has the potential to have a buggy implementation as
> > the comment by Alan Cox shows.)
> For me, this shows two things:
> - I never ever had to use disable_irq_nosync() in any UIO driver yet,
> otherwise I would have noticed.
> - Magnus turned in a patch that he never tested.
Note that the deadlock in question is in relation to SMP, it's true that
the patch was never tested in an SMP environment and only on UP, but it
certainly was tested. The vast majority of driver writers don't have a
need to use disable_irq_nosync(), so whether you've had to use it or not
is largely irrelevant to the conversation at hand ;-)

 \ /
  Last update: 2008-07-03 15:29    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean