Messages in this thread | | | Date | Sun, 13 Jul 2008 18:05:40 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH] x86: let 32bit use apic_ops too |
| |
On Sun, 13 Jul 2008, Suresh Siddha wrote:
> Maciej, Yinghai's current 32bit xapic_* supports both 4-bit apic and xapic.
There is also the 82489DX, which our 32-bit code is meant to support, and which is 8-bit physical, 32-bit logical, and which differs from the other APICs slightly here and there -- please be careful about that.
> Yinghai, may be we should name them as apic_mem_* instead of xapic_* > or any better suggestions?
If you propose to rename the functions from apic_* to apic_mem_* to signify memory-mapped rather then MSR access to the device (how interestingly history repeats itself, with a design dated back to the VAX now reappearing in the x86), then it sounds reasonable to me and you surely have my support.
Maciej
| |