lkml.org 
[lkml]   [2008]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: let 32bit use apic_ops too
On Sat, 12 Jul 2008, Yinghai Lu wrote:

> > Etc... Why are you changing names of these functions? Are they meant
> > not to apply to older APIC implementations anymore?
>
> because 64bit has that name.

Shouldn't it be the other way round then? Our 32-bit code is the
original one and supports more APIC variations than the 64-bit one. So at
the point of unification 64-bit xAPIC-only functions will become universal
ones making the naming counter-intuitive: apic_ -> any APIC, xapic_ ->
xAPIC only. I think only functions specific to the xAPIC should have the
xapic_ prefix.

Maciej


\
 
 \ /
  Last update: 2008-07-13 03:57    [W:0.374 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site