lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware()
From
Date
On Mon, 2008-06-30 at 12:10 -0400, Chas Williams (CONTRACTOR) wrote:
> In message <1214837678.10393.345.camel@pmac.infradead.org>,David Woodhouse writ
> es:
> >> i removed the #ifdef's from around MODULE_LICENSE(). there shouldnt
> >> be any need for #ifdef's around MODULE_FIRMWARE() either.
> >
> >Unless you put #ifdef CONFIG_SBUS around the
> >MODULE_FIRMWARE("sba200e_ecd.bin") you will be requesting that firmware
> >even on non-sbus machines. Likewise little-endian vs. big-endian on PCI.
>
> does it? i was under the impression that MODULE_FIRMWARE() just
> provides a hint that modinfo can read. request_firmware() still
> the requestor for the firmware image.

True. But if you were to put the driver into an initrd, for example,
then the tools would pick out all three firmwares to include in the
initrd too. Given that we _do_ know at runtime that we'll need a maximum
of two of the three, it makes sense to list only the ones we might use.

--
dwmw2



\
 
 \ /
  Last update: 2008-06-30 21:21    [W:2.037 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site