Messages in this thread | | | Date | Mon, 30 Jun 2008 12:46:41 -0700 (PDT) | Subject | Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware() | From | David Miller <> |
| |
From: "Chas Williams (CONTRACTOR)" <chas@cmf.nrl.navy.mil> Date: Mon, 30 Jun 2008 12:10:47 -0400
> In message <1214837678.10393.345.camel@pmac.infradead.org>,David Woodhouse writ > es: > >> i removed the #ifdef's from around MODULE_LICENSE(). there shouldnt > >> be any need for #ifdef's around MODULE_FIRMWARE() either. > > > >Unless you put #ifdef CONFIG_SBUS around the > >MODULE_FIRMWARE("sba200e_ecd.bin") you will be requesting that firmware > >even on non-sbus machines. Likewise little-endian vs. big-endian on PCI. > > does it? i was under the impression that MODULE_FIRMWARE() just > provides a hint that modinfo can read. request_firmware() still > the requestor for the firmware image.
And also, there are systems with both PCI and SBUS so we should make sure we handle that properly here.
| |