Messages in this thread | | | Subject | Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware() | From | David Woodhouse <> | Date | Mon, 30 Jun 2008 10:34:33 +0100 |
| |
On Thu, 2008-06-05 at 12:06 -0400, Chas Williams (CONTRACTOR) wrote: > yes, it is troubling. along the same lines, this patch removes the > pca200e/sba200e firmware from the kernel. the firmware will be in the > next release of the userspace atm tools. i could move the ambassador > firmware there as well if you would like.
Sorry for dropping this; I'll let it go through the net tree now it's there.
A couple of comments though... it looks like you forgot to add MODULE_FIRMWARE(). And shouldn't 'fw_data' in fore200e_load_and_start_firmware() be a (__le32 *) not a (u32 *)?
-- dwmw2
| |