Messages in this thread | | | From | "Chas Williams (CONTRACTOR)" <> | Subject | Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware() | Date | Mon, 30 Jun 2008 08:50:41 -0400 |
| |
In message <1214818473.10393.337.camel@pmac.infradead.org>,David Woodhouse writ es: >Sorry for dropping this; I'll let it go through the net tree now it's >there.
ok
>A couple of comments though... it looks like you forgot to add >MODULE_FIRMWARE(). And shouldn't 'fw_data' in
yes. i will get davem a patch for that asap.
>fore200e_load_and_start_firmware() be a (__le32 *) not a (u32 *)?
yes, it certainly could be.
| |