Messages in this thread | | | Date | Mon, 5 May 2008 17:37:10 +0900 | From | "minchan Kim" <> | Subject | Re: [-mm][PATCH 3/5] change function prototype of shrink_zone() |
| |
OK. I see I seemed to be in a hurry without looking over following patches.
On Mon, May 5, 2008 at 5:31 PM, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > Hi > > > > + sc->nr_reclaimed += nr_reclaimed; > > > throttle_vm_writeout(sc->gfp_mask); > > > - return nr_reclaimed; > > > + return 0; > > > } > > > > I am not sure this is right. > > I might be wrong if this patch is depended on another patch. > > > > As I see, shrink_zone always return 0 in your patch. > > Yeah, this patch is just preparetion change of [4/5]. > I use EAGAIN at [4/5]. > > > > If it is right, I think that return value is useless. It is better > > that we change function return type to "void" > > Also, we have to change functions that call shrink_zone properly. ex) > > balance_pgdat, __zone_reclaim > > That functions still use number of shrink_zone's reclaim page > > this patch is not intent by solo usage. > just intent to bisect friendly. > thus, We need implement that following patch use freature only. > > Thanks! >
-- Thanks, barrios
| |