lkml.org 
[lkml]   [2008]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm][PATCH 3/5] change function prototype of shrink_zone()
>  -static unsigned long shrink_zone(int priority, struct zone *zone,
> - struct scan_control *sc)
> +static int shrink_zone(int priority, struct zone *zone,
> + struct scan_control *sc)
> {
> unsigned long nr_active;
> unsigned long nr_inactive;
> @@ -1236,8 +1239,9 @@ static unsigned long shrink_zone(int pri
> }
> }
>
> + sc->nr_reclaimed += nr_reclaimed;
> throttle_vm_writeout(sc->gfp_mask);
> - return nr_reclaimed;
> + return 0;
> }

I am not sure this is right.
I might be wrong if this patch is depended on another patch.

As I see, shrink_zone always return 0 in your patch.

If it is right, I think that return value is useless. It is better
that we change function return type to "void"
Also, we have to change functions that call shrink_zone properly. ex)
balance_pgdat, __zone_reclaim
That functions still use number of shrink_zone's reclaim page

--
Thanks,
barrios


\
 
 \ /
  Last update: 2008-05-05 06:45    [W:0.094 / U:9.216 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site