Messages in this thread | | | Date | Tue, 20 May 2008 02:20:56 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/3, RFC] watchdog dev BKL pushdown |
| |
On Tue, May 20, 2008 at 01:14:23AM +0200, Arnd Bergmann wrote: > The Big Kernel Lock has been pushed down from chardev_open > to misc_open, this change moves it to the individual watchdog > driver open functions. > > As before, the change was purely mechanical, most drivers > should actually not need the BKL.
Actually I'd prefer to fix this for real. This single open stuff aswell as same set of ioctls are duplicated all over the watchdog drivers. We'd be much better off introducing a simple watchdog layer that handles this plus proper locking and convert drivers over to it gradually.
| |