lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3, RFC] watchdog dev BKL pushdown
    On Tue, 20 May 2008 02:20:56 -0400
    Christoph Hellwig <hch@infradead.org> wrote:

    > On Tue, May 20, 2008 at 01:14:23AM +0200, Arnd Bergmann wrote:
    > > The Big Kernel Lock has been pushed down from chardev_open
    > > to misc_open, this change moves it to the individual watchdog
    > > driver open functions.
    > >
    > > As before, the change was purely mechanical, most drivers
    > > should actually not need the BKL.
    >
    > Actually I'd prefer to fix this for real. This single open stuff aswell
    > as same set of ioctls are duplicated all over the watchdog drivers. We'd
    > be much better off introducing a simple watchdog layer that handles this
    > plus proper locking and convert drivers over to it gradually.

    In progress in two ways

    - Wim was (is ?) working on a proper device layer

    - I've cleaned up all the drivers and am now testing a watchdog
    driver supporting library which is taking about 50% of the code out of
    each driver I convert.

    Alan


    \
     
     \ /
      Last update: 2008-05-20 11:29    [W:0.020 / U:0.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site