Messages in this thread | | | Date | Sun, 18 May 2008 12:47:38 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [RFC] x86: merge nmi_32-64 to nmi.c |
| |
[Jeremy Fitzhardinge - Sun, May 18, 2008 at 09:33:14AM +0100] > Cyrill Gorcunov wrote: >> I think I would prefer Maciej's advice then but with capital >> letters (to easy distinguish them and point an attention) like >> >> #ifdef CONFG_X86_64 >> #define CPU_64 1 >> #else >> #define CPU_64 0 >> #endif > > The other problem in this case is that cpu_pda() doesn't exit for 32-bit, > so it probably won't compile anyway. But in general, I fully support using > if (constant) over #ifdef (?: not so much). > > J >
Since it's a compile-time known path I hope gcc just throw it out before checking for existance. But not tried yet ;)
- Cyrill -
| |