[lkml]   [2008]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC] x86: merge nmi_32-64 to nmi.c
Cyrill Gorcunov wrote:
> I think I would prefer Maciej's advice then but with capital
> letters (to easy distinguish them and point an attention) like
> #ifdef CONFG_X86_64
> #define CPU_64 1
> #else
> #define CPU_64 0
> #endif

The other problem in this case is that cpu_pda() doesn't exit for
32-bit, so it probably won't compile anyway. But in general, I fully
support using if (constant) over #ifdef (?: not so much).


 \ /
  Last update: 2008-05-18 10:37    [W:0.097 / U:7.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site