Messages in this thread | | | Date | Sun, 27 Apr 2008 23:50:23 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH] xfs: reduce stack usage in xfs_page_state_convert() |
| |
On Mon, Apr 28, 2008 at 09:23:17AM +1000, David Chinner wrote: > No. That code is complex enough with only one copy of it around. I don't > want two copies that differ subtly and hence have two different sets > of nasty, rarely hit corner cases in them.
Actually the split makes some sense. I had a ready patch to split out releasepage which makes the whole code a lot nicer. I didn't go forward with it because I had this idea that it would get replaced by Chris extent_map stuff ASAP..
| |