lkml.org 
[lkml]   [2008]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets
Fix harmless but irritating off-by-one bug in patch "firewire: debug
interrupt events". Should be folded into that one.

See OHCI 1.1 clause 8.7.1.4.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/fw-ohci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux/drivers/firewire/fw-ohci.c
===================================================================
--- linux.orig/drivers/firewire/fw-ohci.c
+++ linux/drivers/firewire/fw-ohci.c
@@ -371,10 +371,10 @@ static void log_ar_at_event(char dir, in
if (unlikely(evt >= ARRAY_SIZE(evts)))
evt = 0x1f;

- if (header[0] == ~header[1]) {
+ if (header[1] == ~header[2]) {
printk(KERN_DEBUG "A%c %s, %s, %08x\n",
- dir, evts[evt], phys[header[0] >> 30 & 0x3],
- header[0]);
+ dir, evts[evt], phys[header[1] >> 30 & 0x3],
+ header[1]);
return;
}

--
Stefan Richter
-=====-==--- -=-- -=-==
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2008-04-11 00:53    [W:0.055 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site