Messages in this thread | | | Date | Wed, 26 Mar 2008 10:31:15 -0400 | From | "Mike Frysinger" <> | Subject | Re: [PATCH 1/1] [Blackfin try #2] char driver for Blackfin on-chip OTP memory |
| |
On Wed, Mar 26, 2008 at 6:33 AM, Jiri Slaby <jirislaby@gmail.com> wrote: > On 03/27/2008 02:08 AM, Bryan Wu wrote: > > From: Mike Frysinger <vapier.adi@gmail.com> > > +static int __init bfin_otp_init(void) > > +{ > > + int ret; > > + > > + stampit(); > > + > > + ret = misc_register(&bfin_otp_misc_device); > > + if (ret) { > > + pr_init(KERN_ERR PFX "unable to register a misc device\n"); > > + return ret; > > + } > > + > > + pr_init(KERN_INFO PFX "initialized\n"); > > except the fact, that pr_init definition seems to be broken. Its defined __fmt > is const, so it should reside in .init.rodata (__initconst), not .init.data > (__initdata).
i dont see an __initconst macro anywhere ?
also, it isnt "broken" in the sense that it "doesnt work" ;) -mike
| |