lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] [Blackfin try #2] char driver for Blackfin on-chip OTP memory
On Wed, Mar 26, 2008 at 2:34 PM, Jiri Slaby <jirislaby@gmail.com> wrote:
> On 03/26/2008 03:31 PM, Mike Frysinger wrote:
> > On Wed, Mar 26, 2008 at 6:33 AM, Jiri Slaby <jirislaby@gmail.com> wrote:
> >> On 03/27/2008 02:08 AM, Bryan Wu wrote:
> >> > From: Mike Frysinger <vapier.adi@gmail.com>
> >>> +static int __init bfin_otp_init(void)
> >> > +{
> >> > + int ret;
> >> > +
> >> > + stampit();
> >> > +
> >> > + ret = misc_register(&bfin_otp_misc_device);
> >> > + if (ret) {
> >> > + pr_init(KERN_ERR PFX "unable to register a misc device\n");
> >> > + return ret;
> >> > + }
> >> > +
> >> > + pr_init(KERN_INFO PFX "initialized\n");
> >>
> >> except the fact, that pr_init definition seems to be broken. Its defined __fmt
> >> is const, so it should reside in .init.rodata (__initconst), not .init.data
> >> (__initdata).
> >
> > i dont see an __initconst macro anywhere ?
>
> It's in include/linux/init.h as of 2.6.25-rc2.

driver was developed against ~2.6.21 and that isnt even in 2.6.24,
that's why the drivers dont currently use it

> > also, it isnt "broken" in the sense that it "doesnt work" ;)
>
> Gcc simply doesn't allow that, you likely got 2 sections with init.data, with
> and without readonly bit set, which is wrong, and it seems, that on some systems
> (debian) you won't even compile it.

gcc-4.1.2/binutils-2.17 doesnt have a problem compiling/linking the
code in question. and i imagine i would have noticed a build/link
failure long before testing it on actual hardware.

Bryan can make the changes before pushing for 2.6.25 inclusion ...
otherwise they'll just stay that way until 2.6.25 gets released, and
then i'll do it.
-mike


\
 
 \ /
  Last update: 2008-03-26 19:43    [W:0.046 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site