Messages in this thread Patch in this message | | | Date | Wed, 19 Mar 2008 11:06:02 +0800 | From | "Daolong Wang" <> | Subject | [PATCH]CHECKPATCH:fix misleading output on spaces/tabs error |
| |
I got confused by this line:
"ERROR: use tabs not spaces"
It literally means "use tabs but not spaces is WRONG", which is WRONG.
"ERROR: do not use spaces when tabs expected"
sounds more appropriate.
Signed-off-by: Wang Daolong <ahlongxp@gmail.com> --- --- scripts/checkpatch.pl.org 2008-03-18 23:08:41.000000000 +0800 +++ scripts/checkpatch.pl 2008-03-18 23:19:34.000000000 +0800 @@ -1064,7 +1064,7 @@ sub process { if ($rawline =~ /^\+\s* \t\s*\S/ || $rawline =~ /^\+\s* \s*/) { my $herevet = "$here\n" . cat_vet($rawline) . "\n"; - ERROR("use tabs not spaces\n" . $herevet); + ERROR("do not use spaces when tabs expected\n" . $herevet); }
# check for RCS/CVS revision markers
| |