lkml.org 
[lkml]   [2008]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] gpiolib: add __must_check attribute to the gpiochip_add function
Date
On Wednesday 12 March 2008, Anton Vorontsov wrote:
> On Tue, Mar 11, 2008 at 01:02:38PM -0800, David Brownell wrote:
> > On Tuesday 11 March 2008, Anton Vorontsov wrote:
> > >
> > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> >
> > I'm curious why you want to change this. When it fails, a
> > KERN_ERR message is emitted ...
>
> Ah, I missed that the gpiochip_add() issuing pr_err(), not pr_debug().
>
> So, please just ignore that patch.

OK ...

> Though, printing errors from the
> generic functions is confusing, you never know when your code or the
> function you call should print the error. And usually generic functions
> tend to be silent...

The logic in this case was that I don't really expect platform
setup code to check this stuff any more than it checks IRQ setup.
But, as the comment says, if platform setup code goofs, it can
cause un-bootable systems. Ergo the pr_err().

It could be argued either way; that's just what I did, way back
when I noticed the issue.

- Dave


\
 
 \ /
  Last update: 2008-03-13 00:11    [W:0.070 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site