Messages in this thread | | | Date | Wed, 12 Mar 2008 15:39:13 +0300 | From | Anton Vorontsov <> | Subject | Re: [PATCH 3/3] gpiolib: add __must_check attribute to the gpiochip_add function |
| |
On Tue, Mar 11, 2008 at 01:02:38PM -0800, David Brownell wrote: > On Tuesday 11 March 2008, Anton Vorontsov wrote: > > > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > > I'm curious why you want to change this. When it fails, a > KERN_ERR message is emitted ...
Ah, I missed that the gpiochip_add() issuing pr_err(), not pr_debug().
So, please just ignore that patch. Though, printing errors from the generic functions is confusing, you never know when your code or the function you call should print the error. And usually generic functions tend to be silent...
-- Anton Vorontsov email: cboumailru@gmail.com irc://irc.freenode.net/bd2
| |