lkml.org 
[lkml]   [2008]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] gpiolib: add __must_check attribute to the gpiochip_add function
On Tue, Mar 11, 2008 at 01:02:38PM -0800, David Brownell wrote:
> On Tuesday 11 March 2008, Anton Vorontsov wrote:
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
> I'm curious why you want to change this. When it fails, a
> KERN_ERR message is emitted ...

Ah, I missed that the gpiochip_add() issuing pr_err(), not pr_debug().

So, please just ignore that patch. Though, printing errors from the
generic functions is confusing, you never know when your code or the
function you call should print the error. And usually generic functions
tend to be silent...

--
Anton Vorontsov
email: cboumailru@gmail.com
irc://irc.freenode.net/bd2


\
 
 \ /
  Last update: 2008-03-12 13:41    [W:0.054 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site