Messages in this thread Patch in this message | | | Date | Tue, 19 Feb 2008 02:21:45 -0800 | From | Yinghai Lu <> | Subject | [PATCH] x86_64: fix dma_alloc_pages |
| |
one system with two nodes and two ht links on every node. the bios already have _pxm for two links.
when no ram installed for node1 will have panic.
reason: the device on second chain will get node = 1 from dev_to_node...via pci_acpi_scan_root. but node1 doesn't have ram installed. in dma_alloc_pages it will pass check with first_node(node_online_map)... and will have problem with __alloc_pages in alloc_pages_node.
this patch will check the if the node is online..., if not will get numa_node_id to get one node with ram.
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
diff --git a/arch/x86/kernel/pci-dma_64.c b/arch/x86/kernel/pci-dma_64.c index a82473d..931b51a 100644 --- a/arch/x86/kernel/pci-dma_64.c +++ b/arch/x86/kernel/pci-dma_64.c @@ -53,12 +53,9 @@ dma_alloc_pages(struct device *dev, gfp_t gfp, unsigned order) int node; node = dev_to_node(dev); - if (node == -1) + if (node == -1 || !node_online(node)) node = numa_node_id(); - if (node < first_node(node_online_map)) - node = first_node(node_online_map); - page = alloc_pages_node(node, gfp, order); return page ? page_address(page) : NULL; }
| |